Skip to content

Refactor: remove unused input state handling in CopilotCLIChatSessionContentProvider #309945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 1 commit into from
Apr 14, 2026
Merged

Refactor: remove unused input state handling in CopilotCLIChatSessionContentProvider #309945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ export class CopilotCLIChatSessionContentProvider extends Disposable implements
}
}
));
const inputStateForNewSession = new ResourceMap<WeakRef<vscode.ChatSessionInputState>>();
controller.newChatSessionItemHandler = async (context) => {
const sessionId = this.sessionService.createNewSessionId();
const resource = SessionIdForCLI.getResource(sessionId);
Expand All @@ -185,8 +184,6 @@ export class CopilotCLIChatSessionContentProvider extends Disposable implements

controller.items.add(session);
this.newSessions.set(resource, session);
const groups = await this._optionGroupBuilder.provideChatSessionProviderOptionGroups(context.inputState);
inputStateForNewSession.set(resource, new WeakRef(controller.createChatSessionInputState(groups)));
return session;
};
if (this.configurationService.getConfig(ConfigKey.Advanced.CLIForkSessionsEnabled)) {
Expand Down Expand Up @@ -249,12 +246,7 @@ export class CopilotCLIChatSessionContentProvider extends Disposable implements
const groups = await this._optionGroupBuilder.buildExistingSessionInputStateGroups(sessionResource, token);
return controller.createChatSessionInputState(groups);
} else {
Comment thread
DonJayamanne marked this conversation as resolved.
// Possible we've already handled the newChatSessionItemHandler for this same uri
// In which case the proper inputState would have been sent.
// There's a bug in core where after newChatSessionItemHandler is called, we get
// another call for getChatSessionInputState, but this time the previous input state is incorrect.
const previousInputState = sessionResource ? inputStateForNewSession.get(sessionResource)?.deref() : undefined;
const groups = await this._optionGroupBuilder.provideChatSessionProviderOptionGroups(previousInputState);
const groups = await this._optionGroupBuilder.provideChatSessionProviderOptionGroups(context.previousInputState);
Comment thread
DonJayamanne marked this conversation as resolved.
const state = controller.createChatSessionInputState(groups);
// Only wire dynamic updates for new sessions (existing sessions are fully locked).
// Note: don't use the getChatSessionInputState token here — it's a one-shot token
Expand Down
Loading