Skip to content

Weekly Permissions sync 2025-08-31#1251

Merged
jasonjoh merged 1 commit intopermissions-update/2025-08-30from
permissions-update/2025-08-31
Sep 2, 2025
Merged

Weekly Permissions sync 2025-08-31#1251
jasonjoh merged 1 commit intopermissions-update/2025-08-30from
permissions-update/2025-08-31

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2025-08-31

Copilot AI review requested due to automatic review settings August 31, 2025 00:27
@marabooy marabooy requested a review from a team as a code owner August 31, 2025 00:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is a weekly permissions sync that updates API endpoint permissions in the system. The changes involve reorganizing and normalizing permission configurations for Teams and channel-related endpoints.

  • Removes redundant or unnecessary permission entries from various pathSets
  • Restructures permission schemes to better separate DelegatedWork and Application permissions
  • Consolidates similar endpoint configurations to reduce duplication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +6780 to +6781
"/teams/{id}/channels/{id}/doesuserhaveaccess": "least=DelegatedWork",
"/teams/{id}/channels/{id}/members": "least=DelegatedWork",
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission values are inconsistent - some paths have 'least=DelegatedWork' while others in the same section have empty strings. Consider standardizing the permission format across similar endpoints for better maintainability.

Copilot uses AI. Check for mistakes.
"/chats/{id}/members/{id}": "",
"/teams/{id}/channels/{id}/members/{id}": ""
}
"paths": {}
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty paths object suggests this pathSet configuration may be redundant. Consider removing the entire pathSet block if no paths are defined, as it serves no functional purpose.

Copilot uses AI. Check for mistakes.
],
"paths": {
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork,Application"
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork"
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission value has changed from 'least=DelegatedWork,Application' to 'least=DelegatedWork'. Verify this change doesn't break existing Application-level access patterns for shared team endpoints.

Suggested change
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork"
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork,Application"

Copilot uses AI. Check for mistakes.
@jasonjoh jasonjoh changed the base branch from dev to permissions-update/2025-08-30 September 2, 2025 15:39
@jasonjoh jasonjoh merged commit 58b48d2 into permissions-update/2025-08-30 Sep 2, 2025
4 checks passed
@jasonjoh jasonjoh deleted the permissions-update/2025-08-31 branch September 2, 2025 15:39
jasonjoh added a commit that referenced this pull request Sep 2, 2025
* Weekly Permissions sync 2025-08-30

* Weekly Permissions sync 2025-09-02 (#1253)

* Weekly Permissions sync 2025-09-01 (#1252)

* Weekly Permissions sync 2025-08-31 (#1251)

* Apply suggestions from code review

---------

Co-authored-by: Jason Johnston <jasonjoh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants