Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions permissions/new/ProvisioningInfo.json
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-000000000000"
}
],
],
"AgentIdentityBlueprint.CreateAsManager": [
{
"id": "ecf9c9c0-b7d6-48c0-8ad6-7b00493a2efb",
Expand Down Expand Up @@ -11514,7 +11514,7 @@
"scheme": "DelegatedWork",
"environment": "public",
"isHidden": true,
"isEnabled": true,
"isEnabled": true,
"resourceAppId": "fc780465-2017-40d4-a0c5-307022471b92"
},
{
Expand Down Expand Up @@ -12235,7 +12235,7 @@
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-00000000000"
}
],
],
"ServicePrincipal.Manage.OwnedBy": [
{
"id": "6930b171-5cf8-4865-ba0f-cfce959d1bca",
Expand Down
102 changes: 41 additions & 61 deletions permissions/new/permissions.json
Original file line number Diff line number Diff line change
Expand Up @@ -6775,15 +6775,14 @@
"GET"
],
"paths": {
"/chats/{id}/members/{id}": "",
"/teams/{id}/channels/{id}/allMembers": "least=DelegatedWork",
"/teams/{id}/channels/{id}/allMembers/{id}": "least=DelegatedWork",
"/teams/{id}/channels/{id}/doesuserhaveaccess": "least=DelegatedWork,Application",
"/teams/{id}/channels/{id}/members": "",
"/teams/{id}/channels/{id}/doesuserhaveaccess": "least=DelegatedWork",
"/teams/{id}/channels/{id}/members": "least=DelegatedWork",
Comment on lines +6780 to +6781
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission values are inconsistent - some paths have 'least=DelegatedWork' while others in the same section have empty strings. Consider standardizing the permission format across similar endpoints for better maintainability.

Copilot uses AI. Check for mistakes.
"/teams/{id}/channels/{id}/members/{id}": "least=DelegatedWork",
"/teams/{id}/channels/{id}/sharedwithteams": "least=DelegatedWork,Application",
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork,Application",
"/teams/{id}/channels/{id}/sharedwithteams/{id}/allowedmembers": "least=DelegatedWork,Application"
"/teams/{id}/channels/{id}/sharedwithteams": "least=DelegatedWork",
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork",
"/teams/{id}/channels/{id}/sharedwithteams/{id}/allowedmembers": "least=DelegatedWork"
}
}
],
Expand Down Expand Up @@ -6812,8 +6811,12 @@
"paths": {
"/teams/{id}/channels/{id}/allMembers": "least=Application",
"/teams/{id}/channels/{id}/allMembers/{id}": "least=Application",
"/teams/{id}/channels/{id}/doesuserhaveaccess": "least=Application",
"/teams/{id}/channels/{id}/members": "least=Application",
"/teams/{id}/channels/{id}/members/{id}": "least=Application"
"/teams/{id}/channels/{id}/members/{id}": "least=Application",
"/teams/{id}/channels/{id}/sharedwithteams": "least=Application",
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=Application",
"/teams/{id}/channels/{id}/sharedwithteams/{id}/allowedmembers": "least=Application"
}
}
],
Expand All @@ -6840,10 +6843,7 @@
"methods": [
"GET"
],
"paths": {
"/chats/{id}/members/{id}": "",
"/teams/{id}/channels/{id}/members/{id}": ""
}
"paths": {}
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty paths object suggests this pathSet configuration may be redundant. Consider removing the entire pathSet block if no paths are defined, as it serves no functional purpose.

Copilot uses AI. Check for mistakes.
}
],
"ownerInfo": {
Expand All @@ -6869,17 +6869,6 @@
}
},
"pathSets": [
{
"schemeKeys": [
"Application"
],
"methods": [
"GET"
],
"paths": {
"/chats/{id}/members/{id}": ""
}
},
{
"schemeKeys": [
"DelegatedWork",
Expand All @@ -6889,8 +6878,13 @@
"GET"
],
"paths": {
"/teams/{id}/channels/{id}/allMembers": "",
"/teams/{id}/channels/{id}/allMembers/{id}": "",
"/teams/{id}/channels/{id}/doesuserhaveaccess": "",
"/teams/{id}/channels/{id}/members": "",
"/teams/{id}/channels/{id}/members/{id}": "",
"/teams/{id}/channels/{id}/sharedwithteams": "",
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "",
"/teams/{id}/channels/{id}/sharedwithteams/{id}/allowedmembers": ""
}
},
Expand All @@ -6900,34 +6894,19 @@
"Application"
],
"methods": [
"GET",
"POST"
],
"paths": {
"/teams/{id}/channels/{id}/members": "least=DelegatedWork"
}
},
{
"schemeKeys": [
"DelegatedWork",
"Application"
],
"methods": [
"GET"
],
"paths": {
"/teams/{id}/channels/{id}/allMembers": "",
"/teams/{id}/channels/{id}/allMembers/{id}": ""
}
},
{
"schemeKeys": [
"DelegatedWork",
"Application"
],
"methods": [
"DELETE",
"GET",
"PATCH"
],
"paths": {
Expand All @@ -6940,11 +6919,10 @@
"Application"
],
"methods": [
"DELETE",
"GET"
"DELETE"
],
"paths": {
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork,Application"
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork"
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission value has changed from 'least=DelegatedWork,Application' to 'least=DelegatedWork'. Verify this change doesn't break existing Application-level access patterns for shared team endpoints.

Suggested change
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork"
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=DelegatedWork,Application"

Copilot uses AI. Check for mistakes.
}
}
],
Expand All @@ -6968,23 +6946,28 @@
"Application"
],
"methods": [
"GET",
"POST"
"GET"
],
"paths": {
"/teams/{id}/channels/{id}/members": "least=Application"
"/teams/{id}/channels/{id}/allMembers": "",
"/teams/{id}/channels/{id}/allMembers/{id}": "",
"/teams/{id}/channels/{id}/doesuserhaveaccess": "",
"/teams/{id}/channels/{id}/members": "",
"/teams/{id}/channels/{id}/members/{id}": "",
"/teams/{id}/channels/{id}/sharedwithteams": "",
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "",
"/teams/{id}/channels/{id}/sharedwithteams/{id}/allowedmembers": ""
}
},
{
"schemeKeys": [
"Application"
],
"methods": [
"GET"
"POST"
],
"paths": {
"/teams/{id}/channels/{id}/allMembers": "",
"/teams/{id}/channels/{id}/allMembers/{id}": ""
"/teams/{id}/channels/{id}/members": "least=Application"
}
},
{
Expand All @@ -6993,12 +6976,22 @@
],
"methods": [
"DELETE",
"GET",
"PATCH"
],
"paths": {
"/teams/{id}/channels/{id}/members/{id}": "least=Application"
}
},
{
"schemeKeys": [
"Application"
],
"methods": [
"DELETE"
],
"paths": {
"/teams/{id}/channels/{id}/sharedwithteams/{id}": "least=Application"
}
}
],
"ownerInfo": {
Expand Down Expand Up @@ -24698,7 +24691,7 @@
"/planner/tasks/{id}/details": "",
"/planner/tasks/{id}/progresstaskboardformat": "",
"/policies/ownerlessGroupPolicy": "least=DelegatedWork",
"/teams/{id}/channels/{id}/members": "least=DelegatedWork",
"/teams/{id}/channels/{id}/members": "",
"/teams/{id}/schedule": "",
"/teams/{id}/schedule/offershiftrequests/{id}": "",
"/teams/{id}/schedule/openshiftchangerequests": "",
Expand Down Expand Up @@ -45239,7 +45232,6 @@
],
"paths": {
"/chats/{id}/members/{id}": "",
"/teams/{id}/channels/{id}/members/{id}": "",
"/teams/{id}/members": "least=Application",
"/teams/{id}/members/{id}": "least=Application"
}
Expand Down Expand Up @@ -45268,18 +45260,6 @@
}
},
"pathSets": [
{
"schemeKeys": [
"DelegatedWork",
"Application"
],
"methods": [
"PATCH"
],
"paths": {
"/teams/{id}/channels/{id}/members/{id}": ""
}
},
{
"schemeKeys": [
"DelegatedWork",
Expand Down