Skip to content

update docs to remove old references to frankenphp:static-builder #1950

Merged
henderkes merged 4 commits intophp:mainfrom
henderkes:static-builder-docs
Nov 7, 2025
Merged

update docs to remove old references to frankenphp:static-builder #1950
henderkes merged 4 commits intophp:mainfrom
henderkes:static-builder-docs

Conversation

@henderkes
Copy link
Copy Markdown
Contributor

we have -musl and -gnu, the static-builder image was discontinued with v1.5.0

@henderkes henderkes requested a review from dunglas October 29, 2025 18:27
Copy link
Copy Markdown
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we recommend using the GNU variant?

Comment thread docs/embed.md Outdated
Comment on lines +57 to +58
FROM --platform=linux/amd64 dunglas/frankenphp:static-builder-musl
# If you intend to run the binary on glibc systems, use static-builder-gnu instead
Copy link
Copy Markdown
Contributor Author

@henderkes henderkes Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM --platform=linux/amd64 dunglas/frankenphp:static-builder-musl
# If you intend to run the binary on glibc systems, use static-builder-gnu instead
FROM --platform=linux/amd64 dunglas/frankenphp:static-builder-gnu
# If you intend to run the binary on musl-libc systems, use static-builder-musl instead

like this?

@AlliBalliBaba
Copy link
Copy Markdown
Contributor

Why are the gnu binaries actually bigger than the musl ones? Would have expected the opposite. Otherwise it's probably a better default if you have glibc.

@henderkes
Copy link
Copy Markdown
Contributor Author

Because they retain all the necessary symbols to load php extensions, while the musl version, which can't lead shared libraries, strips all that code out.

@henderkes
Copy link
Copy Markdown
Contributor Author

This reminds me that I need to get the frankenphp embed app branch ready in static-php-cli. It will make the build process much simpler and the resulting binary smaller. It's just the docker support holding it back.

Copy link
Copy Markdown
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, did you use an LLM for the translation?

@henderkes
Copy link
Copy Markdown
Contributor Author

Out of curiosity, did you use an LLM for the translation?

I wish I didn't, hahaha. Unfortunately I'm only fluent in German and English, my French is only good enough for basic checks. PhpStorm licenses come with some LLM contingent and I'm not using it for anything else.

It's not optimal, but it would be a massive effort, for more people than we have, to keep all translations up-to-date otherwise.

@alexandre-daubois
Copy link
Copy Markdown
Member

To me that's ok, especially for this kind of change. I would be a bit more skeptical in case oh whole pages, but for a sentence here and there, I think they're great 🙂

@henderkes henderkes merged commit b22bdd9 into php:main Nov 7, 2025
54 of 55 checks passed
@henderkes henderkes deleted the static-builder-docs branch November 7, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants