update docs to remove old references to frankenphp:static-builder #1950
update docs to remove old references to frankenphp:static-builder #1950
Conversation
… have -musl and -gnu)
dunglas
left a comment
There was a problem hiding this comment.
Shouldn't we recommend using the GNU variant?
| FROM --platform=linux/amd64 dunglas/frankenphp:static-builder-musl | ||
| # If you intend to run the binary on glibc systems, use static-builder-gnu instead |
There was a problem hiding this comment.
| FROM --platform=linux/amd64 dunglas/frankenphp:static-builder-musl | |
| # If you intend to run the binary on glibc systems, use static-builder-gnu instead | |
| FROM --platform=linux/amd64 dunglas/frankenphp:static-builder-gnu | |
| # If you intend to run the binary on musl-libc systems, use static-builder-musl instead |
like this?
|
Why are the gnu binaries actually bigger than the musl ones? Would have expected the opposite. Otherwise it's probably a better default if you have glibc. |
|
Because they retain all the necessary symbols to load php extensions, while the musl version, which can't lead shared libraries, strips all that code out. |
|
This reminds me that I need to get the frankenphp embed app branch ready in static-php-cli. It will make the build process much simpler and the resulting binary smaller. It's just the docker support holding it back. |
alexandre-daubois
left a comment
There was a problem hiding this comment.
Out of curiosity, did you use an LLM for the translation?
I wish I didn't, hahaha. Unfortunately I'm only fluent in German and English, my French is only good enough for basic checks. PhpStorm licenses come with some LLM contingent and I'm not using it for anything else. It's not optimal, but it would be a massive effort, for more people than we have, to keep all translations up-to-date otherwise. |
|
To me that's ok, especially for this kind of change. I would be a bit more skeptical in case oh whole pages, but for a sentence here and there, I think they're great 🙂 |
we have -musl and -gnu, the static-builder image was discontinued with v1.5.0