Skip to content

Change default method in Location.get_sun_rise_set_transit#2410

Merged
kandersolar merged 3 commits intopvlib:mainfrom
AdamRJensen:update_default_sunrise_method
Mar 17, 2025
Merged

Change default method in Location.get_sun_rise_set_transit#2410
kandersolar merged 3 commits intopvlib:mainfrom
AdamRJensen:update_default_sunrise_method

Conversation

@AdamRJensen
Copy link
Copy Markdown
Member

@AdamRJensen AdamRJensen commented Mar 14, 2025

  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I would like to suggest that we switch the default method of pvlib.location.Location.get_sun_rise_set_transit to spa instead of pyephem.

The main reason is that I think it's annoying that we're defaulting to a method that requires the installation of an optional external package when we have functions within pvlib that can do this.

Also, as pointed out by @cwhanse in #1631 (comment), the pyephem package is in maintenance-only mode, which is another reason not to rely to much on this.

@kandersolar kandersolar added this to the v0.12.0 milestone Mar 14, 2025
Comment thread docs/sphinx/source/whatsnew/v0.11.3.rst Outdated
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@kandersolar kandersolar merged commit 0b6e169 into pvlib:main Mar 17, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants