perf: lazily resolve immutable asset info#38
Merged
chenjiahan merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes dev-middleware request handling by avoiding per-request asset info map creation and instead resolving immutable asset metadata only for the matched asset.
Changes:
- Update
getPathsto return thecompilationobject instead of precomputing anassetsInfomap. - Update filename resolution to lazily query
compilation.getAsset(assetName)?.info?.immutablefor immutable cache behavior.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| types/utils/getPaths.d.ts | Updates typings to reflect getPaths returning compilation and removing assetsInfo. |
| src/utils/getPaths.js | Stops building an assets info map on every request; returns compilation for later lookup. |
| src/utils/getFilenameFromUrl.js | Switches immutable detection from prebuilt map to per-asset lazy lookup via compilation.getAsset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the per-request asset info map construction in dev middleware and resolves immutable asset metadata lazily for the matched asset only. This keeps the existing cache header behavior while avoiding
compilation.getAssets()on the request hot path.Related Links
2.0.0-rc.1web-infra-dev/rspack#13709