improvement(popover): added keyboard nav to tag dropdown popover to iterate over parent & child items#1903
Merged
waleedlatif1 merged 3 commits intostagingfrom Nov 11, 2025
Merged
Conversation
added 2 commits
November 11, 2025 14:43
…terate over parent & child items
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR adds keyboard navigation to the tag dropdown popover, enabling users to navigate through both parent tags and their children using arrow keys. Previously, keyboard navigation ignored parent objects. Key Changes:
Implementation Details:
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant TagDropdown
participant KeyboardNav
participant PopoverContext
participant PopoverBackButton
User->>TagDropdown: Opens tag dropdown (< trigger)
TagDropdown->>KeyboardNav: Mount with visible=true
KeyboardNav->>KeyboardNav: Calculate visibleIndices
Note over KeyboardNav: Root level: all non-child tags<br/>In folder: parent tag + children
User->>KeyboardNav: Press ArrowDown/ArrowUp
KeyboardNav->>KeyboardNav: Navigate through visibleIndices
KeyboardNav->>TagDropdown: Update selectedIndex
TagDropdown->>TagDropdown: Scroll item into view
User->>KeyboardNav: Press ArrowRight on parent tag
KeyboardNav->>KeyboardNav: openFolderWithSelection()
KeyboardNav->>PopoverContext: openFolder(id, title, onLoad, onSelect)
PopoverContext->>PopoverContext: Store onFolderSelect callback
KeyboardNav->>TagDropdown: setSelectedIndex to first child
Note over KeyboardNav: Bug: should select parent, not first child
TagDropdown->>PopoverBackButton: Render with parent tag
PopoverBackButton->>PopoverBackButton: Show selectable folder title
User->>KeyboardNav: Navigate in folder
KeyboardNav->>KeyboardNav: Use folder visibleIndices
Note over KeyboardNav: Parent tag is first item
User->>KeyboardNav: Press Enter on parent tag
KeyboardNav->>TagDropdown: handleTagSelect(parentTag)
TagDropdown->>User: Insert parent tag into input
User->>PopoverBackButton: Press ArrowLeft
KeyboardNav->>PopoverContext: closeFolder()
PopoverContext->>PopoverContext: Clear onFolderSelect
KeyboardNav->>TagDropdown: Navigate to first root item
|
Collaborator
Author
|
@greptile |
e381e1a to
b9bfac1
Compare
waleedlatif1
added a commit
that referenced
this pull request
Nov 12, 2025
…terate over parent & child items (#1903) * improvement(popover): added keyboard nav to tag dropdown popover to iterate over parent & child items * code cleanup * ack PR comments
waleedlatif1
added a commit
that referenced
this pull request
Nov 12, 2025
…terate over parent & child items (#1903) * improvement(popover): added keyboard nav to tag dropdown popover to iterate over parent & child items * code cleanup * ack PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist