Skip to content

chore: update ws dependency to version 8.19.0#691

Merged
alexander-akait merged 5 commits intowebpack:mainfrom
bjohansebas:update-ws
Jan 19, 2026
Merged

chore: update ws dependency to version 8.19.0#691
alexander-akait merged 5 commits intowebpack:mainfrom
bjohansebas:update-ws

Conversation

@bjohansebas
Copy link
Copy Markdown
Member

Summary

to update the dependency and stay up to date

Breaking changes: https://github.com/websockets/ws/releases/tag/8.0.0

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

@evenstensberg
Copy link
Copy Markdown
Member

Could you please try to fix the ci? Looks like some regexs are failing.

@bjohansebas
Copy link
Copy Markdown
Member Author

yep, I'm testing it, that's why it's in draft

@bjohansebas bjohansebas changed the title chore: update sirv dependency to version 3.0.2 chore: update ws dependency to version 8.19.0 Jan 18, 2026
@bjohansebas
Copy link
Copy Markdown
Member Author

The issue stems from a change that occurred between versions 7.3.1 and 7.5.10. I’m still investigating further why the server is being shut down twice.

@bjohansebas
Copy link
Copy Markdown
Member Author

bjohansebas commented Jan 18, 2026

The issue originated from this commit in ws, I’m going to investigate whether this is something we need to change on our side, or if it’s solely an issue with ws.

websockets/ws@8806aa9

@bjohansebas
Copy link
Copy Markdown
Member Author

It’s interesting, before that change, chunks were not returned if there was an error; now they are. Because of this, the server can no longer be closed every time data is received — it has to be handled outside of the data event.

@bjohansebas bjohansebas marked this pull request as ready for review January 18, 2026 17:47
Copy link
Copy Markdown
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Care to add a changelog entry?

@bjohansebas
Copy link
Copy Markdown
Member Author

done

@alexander-akait alexander-akait merged commit 72c9027 into webpack:main Jan 19, 2026
5 checks passed
@bjohansebas bjohansebas deleted the update-ws branch January 19, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants