chore: update ws dependency to version 8.19.0#691
chore: update ws dependency to version 8.19.0#691alexander-akait merged 5 commits intowebpack:mainfrom
Conversation
|
Could you please try to fix the ci? Looks like some regexs are failing. |
|
yep, I'm testing it, that's why it's in draft |
|
The issue stems from a change that occurred between versions 7.3.1 and 7.5.10. I’m still investigating further why the server is being shut down twice. |
|
The issue originated from this commit in |
|
It’s interesting, before that change, chunks were not returned if there was an error; now they are. Because of this, the server can no longer be closed every time data is received — it has to be handled outside of the |
valscion
left a comment
There was a problem hiding this comment.
Looks good to me! Care to add a changelog entry?
|
done |
Summary
to update the dependency and stay up to date
Breaking changes: https://github.com/websockets/ws/releases/tag/8.0.0
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?