fix: update redirect logic for URLs ending with '/'

[bjohansebas]

Summary

Okay, this took me a bit of time to understand. This is something similar to what send does. After several attempts, it can probably be refactored even more, but this would be the main solution.

The send workflow is: if it detects a trailing slash at the end of pathname ("/") (line of code), then it goes into another code path, where it joins the original pathname and appends the index (line of code which is configurable, just like in this package). When they are joined, if such an index file exists, it continues with the normal workflow, otherwise, it throws an error, similar to what is handled here. The difference is that now, if there is a trailing slash, the index file (which is configurable) is also appended

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

yes!

If relevant, what needs to be documented once your changes are merged or what have you already documented?

[codecov]

Codecov Report

❌ Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.70%. Comparing base (43f22c4) to head (ee8725d).
⚠️ Report is 56 commits behind head on main.

Files with missing lines	Patch %	Lines
src/middleware.js	97.22%	1 Missing ⚠️
src/utils/getFilenameFromUrl.js	95.83%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
- Coverage   95.88%   95.70%   -0.19%     
==========================================
  Files          13       13              
  Lines         900      907       +7     
  Branches      270      267       -3     
==========================================
+ Hits          863      868       +5     
- Misses         37       39       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bjohansebas]

friendly ping @alexander-akait

[alexander-akait]

I think we need better logic here, because our logic to search index below, so I think we should split it, i.e. like we have in the send package, if it is ends on / we need to apply this logic, otherwise no, right now we just mix this logic

[bjohansebas]

We’re already doing it :)

webpack-dev-middleware/src/utils/getFilenameFromUrl.js

Line 114 in ee8725d

if (pathname && pathname.endsWith("/")) {

[bjohansebas]

The reason for using || is to prevent it from being undefined, because it was throwing an error since there’s no index. But if you add "", it behaves the same way and doesn’t add anything.

[alexander-akait]

@bjohansebas hm, I always thought that our logic is different here, I will look deeply tomorrow

[bjohansebas]

Not so much in the PR description, there’s a bit about how send implements this functionality.

[alexander-akait]

@bjohansebas in my TODO, I almost finished with the new major release of webpack-cli (release will be tomorrow), the next is webpack-dev-middleware

[alexander-akait]

@bjohansebas Rewritting #2290 to be fully align with sync, maybe in future we will introduce the redirect option wth different values to allow make redirect or return content or 404 if a request is a dir, but let's postpone it, anyway thank you for your PR

[alexander-akait]

Feel free to feedback