Skip to content

fix: update logic for URLs ending with '/'#2290

Merged
alexander-akait merged 6 commits intomainfrom
fix-logic-for-trailing-slash
Mar 19, 2026
Merged

fix: update logic for URLs ending with '/'#2290
alexander-akait merged 6 commits intomainfrom
fix-logic-for-trailing-slash

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

Summary

fix - logic for trailing slash

What kind of change does this PR introduce?

fix

Did you add tests for your changes?

WIP

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No

Use of AI

Nothing

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 18, 2026

⚠️ No Changeset found

Latest commit: ee4f6eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
webpack-dev-middleware Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexander-akait
Copy link
Copy Markdown
Member Author

TODOs:

  • more tests around index
  • make it async

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.28%. Comparing base (a0da5d0) to head (ee4f6eb).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/middleware.js 85.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
- Coverage   96.11%   95.28%   -0.83%     
==========================================
  Files           3        3              
  Lines         900      934      +34     
  Branches      266      282      +16     
==========================================
+ Hits          865      890      +25     
- Misses         35       44       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait alexander-akait merged commit 749b6ea into main Mar 19, 2026
28 of 31 checks passed
@alexander-akait alexander-akait deleted the fix-logic-for-trailing-slash branch March 19, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant