Allow SubjectInfoAccess extension without id-ad-caRepository entry#10368
Open
holtrop-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Allow SubjectInfoAccess extension without id-ad-caRepository entry#10368holtrop-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
holtrop-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Relaxes X.509 Subject Information Access (SIA) parsing so certificates without an id-ad-caRepository access method are accepted (RFC 5280-compliant), and adds a regression test plus supporting test-certificate generation artifacts.
Changes:
- Remove the hard failure in
DecodeSubjInfoAcc()whenid-ad-caRepositoryis absent. - Add an API test covering SIA present but without
id-ad-caRepository. - Add a new SIA test certificate and update cert regeneration scripts/configs (plus ignore
.rnd).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
wolfcrypt/src/asn.c |
Stops rejecting SIA extensions that don’t include id-ad-caRepository. |
tests/api.c |
Adds a regression test that parses a cert with SIA but no caRepository entry. |
certs/sia/timestamping-sia-cert.pem |
New test certificate containing SIA with only timeStamping access method. |
certs/renewcerts/wolfssl.cnf |
Adds an OpenSSL config section to generate the new SIA test cert. |
certs/renewcerts.sh |
Adds regeneration steps for the new SIA test cert; improves cleanup and makes script cwd-independent. |
.gitignore |
Ignores generated certs/.rnd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
holtrop-wolfssl
force-pushed
the
gh10359
branch
2 times, most recently
from
dc57e42 to
b0f0c95
Compare
|
Contributor
Author
|
retest this please (hudson.AbortException: Build 'PRB-multi-test-script' failed with result: FAILURE) |
Previously parsing a SubjectInfoAccess certificate containing a SubjectInfoAccess extension that did not contain an id-ad-caRepository resulted in an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously parsing a SubjectInfoAccess certificate containing a SubjectInfoAccess extension that did not contain an id-ad-caRepository resulted in an error.
Description
Fixes #10359
Testing
Generated certificate with SIA extension without id-ad-caRepository OID present. Tested that
wc_ParseCert()failed before change and passed afterward.Checklist