Skip to content

feat(Datastore): Datastore V2 PR Iteration#9

Merged
yash30201 merged 6 commits intoyash30201:datastore-php-v2from
googleapis:datastore-php-v2-patch
May 10, 2024
Merged

feat(Datastore): Datastore V2 PR Iteration#9
yash30201 merged 6 commits intoyash30201:datastore-php-v2from
googleapis:datastore-php-v2-patch

Conversation

@yash30201
Copy link
Copy Markdown
Owner

@yash30201 yash30201 commented May 10, 2024

More changes for googleapis#7179

  • Remove Old remaining gapic classes
  • Refactor all the unit and system tests in Datastore library to use direct mocking of the RequestHandler::sendRequest() method instead of using the test helper method DatastoreOperationRefreshTrait::mockSendRequest.
  • Remove the now-obselete DatastoreOperationRefreshTrait::mockSendRequest() method.

@yash30201 yash30201 changed the title fix(Datastore): Refactor all the unit and system tests feat(Datastore): Datastore V2 PR Iteration May 10, 2024
@yash30201 yash30201 marked this pull request as ready for review May 10, 2024 11:56
@yash30201 yash30201 merged commit 15747c8 into yash30201:datastore-php-v2 May 10, 2024
@yash30201 yash30201 deleted the datastore-php-v2-patch branch May 10, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant