feat(Datastore): Datastore V2 PR Iteration

Core/src/Testing/DatastoreOperationRefreshTrait.php

@@ -32,6 +32,8 @@
  */
 trait DatastoreOperationRefreshTrait
 {
+    private static Serializer $_serializer;
+
     /**
      * Refresh the operation property of a given stubbed class.
      *
@@ -74,59 +76,19 @@ public function refreshOperation($stub, RequestHandler $requestHandler, array $o
     }
 
     /**
-     * Helper method for Unit and Snippet test classes. This mocks the
-     * $requestHandler class property present in the Test Class with
-     * given arguments.
-     *
-     * @param string $methodName The method name to mock in RequestHandler::sendRequest
-     * @param array<string, mixed> $params The parameters to look for in the
-     * array equivalent of rpc request.
-     * @param mixed $returnValue The value to be returned by sendRequest mock.
-     * @param null|int $shouldBeCalledTimes Adds a shouldBeCalled prophecy. Defaults to `null`, implying nothing is added.
-     * [
-     *      `0` => `shouldBeCalled`,
-     *      Non zero positive integer $x => `shouldBeCalledTimes($x)`
-     * ]
+     * @return Serializer
      */
-    private function mockSendRequest($methodName, $params, $returnValue, $shouldBeCalledTimes = null)
+    private function getSerializer()
     {
-        $serializer = $this->getSerializer();
-
-        $prophecy = $this->requestHandler->sendRequest(
-            DatastoreClient::class,
-            $methodName,
-            Argument::that(function ($arg) use ($methodName, $params, $serializer) {
-                $requestName = ucfirst($methodName . 'Request');
-                $x = explode('\\', get_class($arg));
-                $argName = end($x);
-
-                if ($requestName != $argName) {
-                    return false;
-                }
-                $data = $serializer->encodeMessage($arg);
-                return array_replace_recursive($data, $params) == $data;
-            }),
-            Argument::cetera()
-        );
-
-        if (!is_null($shouldBeCalledTimes)) {
-            if ($shouldBeCalledTimes == 0) {
-                $prophecy->shouldBeCalled();
-            } else {
-                $prophecy->shouldBeCalledTimes($shouldBeCalledTimes);
-            }
+        if (isset(self::$_serializer)) {
+            return self::$_serializer;
         }
 
-        $prophecy->willReturn($returnValue);
-    }
-
-    private function getSerializer()
-    {
         if (isset($this->serializer)) {
-            return $this->serializer;
+            return self::$_serializer = $this->serializer;
         }
 
-        return new Serializer([], [
+        return self::$_serializer = new Serializer([], [
             'google.protobuf.Value' => function ($v) {
                 return $this->flattenValue($v);
             },