Update ee13b5 and 1a02b0 rules to clarify that transcript for video content does not need to be visible by giacomo-petri · Pull Request #2187 · act-rules/act-rules.github.io

giacomo-petri · 2024-05-03T09:39:47Z

Closes issue(s): #2186

Updates:

Added 1.3.1 secondary requirement for both:
- Video element visual-only content has transcript (ee13b5)
- Audio and visuals of video element have transcript (1a02b0)
Removed "visible" from Expectation of both:
- Video element visual-only content has transcript (ee13b5)
- Audio and visuals of video element have transcript (1a02b0)
Added assumption as per CG decision for both:
- Video element visual-only content has transcript (ee13b5)
- Audio and visuals of video element have transcript (1a02b0)
Added non-visible transcription passed example (Passed Example 3) for both:
- Video element visual-only content has transcript (ee13b5)
- Audio and visuals of video element have transcript (1a02b0)
Tweaked a little bit the wording of other passed examples to clarify they are visible and differentiate them from the non-visible one.
Added failing example (Failed Example 3) of transcript not included in the acc tree only for "Audio and visuals of video element have transcript (1a02b0)" since the other rule already had this failure in place.

Need for Call for Review:
This will require a 2 weeks Call for Review

Pull Request Etiquette

When creating PR:

Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR.
Add label to indicate if it's a Rule, Definition or Chore.
Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

…media

Jym77 · 2024-05-23T09:52:55Z

+#### Failed Example 3
+This `video` element has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][].
+```html
+<html lang="en">
+<video controls>
+  <source src="/test-assets/rabbit-video/video.mp4" type="video/mp4"></source>
+  <source src="/test-assets/rabbit-video/video.webm" type="video/webm"></source>
+</video>
+<p aria-hidden="true">The above video shows a giant fat rabbit climbing out of a hole in the ground.
+He stretches, yaws, and then starts walking.
+Then he stops to scratch his bottom.</p>
+</html>
+```
+


This collides with the changes made in #2064.

Thanks for catching that. Requested more details in #2186

This PR is removing "included in the accessibility tree" from the expectation. This will be a passed example since a transcript is available.

#2186 (comment)

This PR is the correct direction. We remove the change from 2064. AG decided that transcripts aren't strictly required to be visible.

giacomo-petri · 2024-05-30T06:24:42Z

Blocked by #2064 (pending merge of #2064)

WilcoFiers

LGTM, although please accept the editorial

WilcoFiers · 2024-08-29T13:58:40Z

+#### Failed Example 3
+This `video` element has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][].
+```html
+<html lang="en">
+<video controls>
+  <source src="/test-assets/rabbit-video/video.mp4" type="video/mp4"></source>
+  <source src="/test-assets/rabbit-video/video.webm" type="video/webm"></source>
+</video>
+<p aria-hidden="true">The above video shows a giant fat rabbit climbing out of a hole in the ground.
+He stretches, yaws, and then starts walking.
+Then he stops to scratch his bottom.</p>
+</html>
+```
+


This PR is the correct direction. We remove the change from 2064. AG decided that transcripts aren't strictly required to be visible.

Can you have another look at this?

Jym77 · 2025-02-07T12:12:16Z

Discussion during F2F meeting:
WCAG is moving toward saying that transcript do not necessarily need to be visible (reason, a gif qualifies as audio-less video, and an aria-label (not visible) is enough for it).

Hence, we should continue with this PR (and close #2064).
We should add a background note explaining the reasoning.
We should add a Passed Example with a video element and an aria-label.
We could add a Best Practice rule requiring transcript t be visible.

kengdoj

I've added comments for your review.

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

netlify · 2025-08-04T14:00:29Z

✅ Deploy Preview for act-rules ready!

Name	Link
🔨 Latest commit	`c4c48c6`
🔍 Latest deploy log	https://app.netlify.com/projects/act-rules/deploys/689997ad8945d80008d06065
😎 Deploy Preview	https://deploy-preview-2187--act-rules.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

add a blank line

giacomo-petri · 2025-08-22T08:59:13Z

Call for review ends September 8th.

mraccess77 · 2025-08-22T12:57:52Z

Personally I think an aria-label text equivalent under 1.1.1 is different than a transcript under 1.2.1. I still don't know how a person with low vision who isn't using a screen reader would be able to access or even know a transcript is available if it's positions off-screen with CSS.

giacomo-petri added 2 commits May 3, 2024 11:24

Address clarification about non-visible transcription for video-only …

0d83c20

…media

Update video-transcript-1a02b0.md

0cbfe66

giacomo-petri added the reviewers wanted label May 3, 2024

giacomo-petri self-assigned this May 3, 2024

Update video-transcript-1a02b0.md

86a5ee6

giacomo-petri requested review from Jym77, bruce-usab, carlosapaduarte and kengdoj May 3, 2024 09:40

giacomo-petri changed the title ~~Giacomo petri video only transcript patch~~ Update ee13b5 and 1a02b0 rules to clarify that transcript for video content does not need to be visible May 3, 2024

giacomo-petri mentioned this pull request May 17, 2024

Transcript for video content does not need to be visible (ee13b5, 1a02b0) #2186

Closed

Jym77 previously requested changes May 23, 2024

View reviewed changes

Update video-only-transcript-ee13b5.md

551e806

giacomo-petri added On hold Blocked Blocked by another PR/Issue and removed reviewers wanted labels May 30, 2024

WilcoFiers approved these changes Aug 29, 2024

View reviewed changes

WilcoFiers requested a review from Jym77 August 29, 2024 16:51

kengdoj requested changes Jul 31, 2025

View reviewed changes

Comment thread _rules/video-only-transcript-ee13b5.md Outdated

Comment thread _rules/video-transcript-1a02b0.md

Comment thread _rules/video-transcript-1a02b0.md Outdated

Update _rules/video-transcript-1a02b0.md

609219d

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

giacomo-petri and others added 2 commits August 4, 2025 16:02

Update _rules/video-only-transcript-ee13b5.md

b3a092e

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update _rules/video-transcript-1a02b0.md

922d9bf

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

giacomo-petri removed On hold Blocked Blocked by another PR/Issue labels Aug 4, 2025

giacomo-petri added 2 commits August 4, 2025 16:11

Update video-only-transcript-ee13b5.md

f2b99f7

Update video-transcript-1a02b0.md

4c44dad

kengdoj reviewed Aug 7, 2025

View reviewed changes

Comment thread _rules/video-transcript-1a02b0.md

kengdoj reviewed Aug 7, 2025

View reviewed changes

Comment thread _rules/video-transcript-1a02b0.md

Apply suggestions from code review

7f864e7

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

giacomo-petri requested a review from kengdoj August 8, 2025 12:36

kengdoj reviewed Aug 8, 2025

View reviewed changes

Comment thread _rules/video-transcript-1a02b0.md

Update _rules/video-transcript-1a02b0.md

a70a1ba

add a blank line

kengdoj reviewed Aug 8, 2025

View reviewed changes

Comment thread _rules/video-transcript-1a02b0.md

Update _rules/video-transcript-1a02b0.md

739ec88

add a blank line

kengdoj approved these changes Aug 8, 2025

View reviewed changes

giacomo-petri added the reviewers wanted label Aug 11, 2025

giacomo-petri added 3 commits August 11, 2025 09:07

fixed headings per new format

ea3f6e4

fix headings per new format

dd37459

Merge branch 'develop' into giacomo-petri-video-only-transcript-patch

c4c48c6

carlosapaduarte approved these changes Aug 21, 2025

View reviewed changes

giacomo-petri added Review call 2 weeks Call for review for new rules and big changes and removed reviewers wanted labels Aug 22, 2025

WilcoFiers merged commit ed3ac22 into develop Oct 9, 2025
6 checks passed

WilcoFiers deleted the giacomo-petri-video-only-transcript-patch branch October 9, 2025 14:59

Jym77 mentioned this pull request Oct 16, 2025

SIA-R24, SIA-R33 remove transcript visibility requirement Siteimprove/alfa#1899

Merged

Jym77 mentioned this pull request Oct 27, 2025

"Video element visual-only content has transcript" [ee13b5] Remove incorrect Failed Example #2367

Merged

7 tasks

Conversation

giacomo-petri commented May 3, 2024

Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

Uh oh!

Uh oh!

Jym77 May 23, 2024

Choose a reason for hiding this comment

Uh oh!

giacomo-petri May 24, 2024

Choose a reason for hiding this comment

Uh oh!

kengdoj May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WilcoFiers Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

giacomo-petri commented May 30, 2024

Uh oh!

WilcoFiers left a comment

Choose a reason for hiding this comment

Uh oh!

WilcoFiers Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jym77 commented Feb 7, 2025

Uh oh!

kengdoj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify Bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for act-rules ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

giacomo-petri commented Aug 22, 2025

Uh oh!

mraccess77 commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kengdoj May 29, 2024 •

edited

Loading

netlify Bot commented Aug 4, 2025 •

edited

Loading