util: fix util for changes to channel-credentials.ts in grpc-js#212
Merged
tstirrat15 merged 5 commits intoauthzed:mainfrom Apr 14, 2025
Merged
util: fix util for changes to channel-credentials.ts in grpc-js#212tstirrat15 merged 5 commits intoauthzed:mainfrom
channel-credentials.ts in grpc-js#212tstirrat15 merged 5 commits intoauthzed:mainfrom
Conversation
Contributor
|
I'll have a look at this soon - I do want to get this fixed. I don't fully understand how composition of these |
tstirrat15
reviewed
Apr 9, 2025
Contributor
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
See comments - otherwise this looks good to me. Thanks for putting this through!
Comment on lines
+31
to
+35
|
|
||
| _createSecureConnector( |
Contributor
There was a problem hiding this comment.
Suggested change
| _createSecureConnector( | |
| // NOTE: this is copied from the InsecureChannelCredentialsImpl class | |
| _createSecureConnector( |
kartikaysaxena
force-pushed
the
fix-util
branch
from
dce5869 to
132569f
Compare
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
kartikaysaxena
force-pushed
the
fix-util
branch
from
885b998 to
052d161
Compare
Contributor
Author
|
updates the imports |
tstirrat15
reviewed
Apr 14, 2025
tstirrat15
reviewed
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #206
Implemented basic
_createSecureConnectorand madecallCredsprivate to fix broken stuff (this PR), tested locally, also updates example